Repository navigation
Correctly format negative single digit cent amounts. - #782
Conversation
Negative cent amounts from -1 to -9 were incorrectly formatted to be 0.1 and 0.9. The issue was the negative sign '-' which caused the padding to be off by one. A test including a negative number was also added. This completes the fix in oss-apps#591.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Format bigint currency amounts src/utils/numbers.ts, src/tests/number.test.ts |
parseToCleanString uses the absolute bigint value for its integer and fractional components. The test covers positive and negative single-digit cents, both expecting '$0.07'. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers: friesischscott
Merge Risk: 
8ee4b
-
The negative single-digit cent formatting issue is corrected without an identified merge-blocking risk.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: correcting formatting for negative single-digit cent amounts. Description check The description explains the formatting defect, identifies the cause, notes the added test, and completes all checklist items. The optional demo section is omitted, but this does not prevent approval. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Cool, thanks |
Description
Negative cent amounts from -1 to -9 were incorrectly formatted to be 0.1 and 0.9 respectively. The issue was the negative sign '-' which caused the padding to be off by one.
A test including a negative number was also added.
This completes the fix in #591.
Checklist
CONTRIBUTING.mdin its entiretySummary by CodeRabbit
-7ndisplays as$0.07.